Fix underflow in fee estimation in the presence of withdrawal and max amount #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| , expectField (#estimatedMax . #getQuantity) (.<= oneAda) | ||
| ] | ||
|
|
||
| it "TRANS_ESTIMATE_03b - we see result when we can't cover fee (with withdrawal)" $ \ctx -> do |
There was a problem hiding this comment.
Suggested change
| it "TRANS_ESTIMATE_03b - we see result when we can't cover fee (with withdrawal)" $ \ctx -> do | |
| it "TRANS_ESTIMATE_03b - we see result when we can't cover fee \ | |
| \(with withdrawal)" $ \ctx -> do |
piotr-iohk
approved these changes
Aug 31, 2020
…of withdrawal This currently fails, 'as expected', next commit will fix the issue.
…flow in fee calculation.
…es beyond a certain amount. This should _not_ be the case, but the contrary would be disastrous for the user. I was getting a little paranoid about this recently, so I think having the wallet crash loudly in such case is a good and sane idea.
KtorZ
force-pushed
the
KtorZ/2062/fix-underflow-fee-estimation-withdrawal
branch
from
10ab550 to
f0e7ae2
Compare
|
bors r+ |
KtorZ
added
the
RESOLVING ISSUE
Build succeeded |
iohk-bors
bot
deleted the
KtorZ/2062/fix-underflow-fee-estimation-withdrawal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2062
Overview
10ab550 out of paranoia, add an invariant to make transactions never leave fees beyond a certain amount.
3d4469c pass down withdrawal value to 'handleCannotCoverFee' to prevent underflow in fee calculation.
f6e74dc add extra scenario covering fee estimation edge-case in the presence of withdrawal
TODO: I'd like to add one property or scenario to exercise the invariant and shows that it operates as expected.
Comments